Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Orbit interpolation #212

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Mar 14, 2024

Orbit interpolation!

@jnibauer, you can use this to model InterpolatedMockStream. That will be really awesome to have!

@nstarman nstarman added this to the v0.1 milestone Mar 14, 2024
@nstarman nstarman requested a review from jnibauer March 14, 2024 04:39
@nstarman nstarman marked this pull request as ready for review March 14, 2024 04:51
@nstarman nstarman marked this pull request as draft March 14, 2024 05:01
@nstarman
Copy link
Contributor Author

nstarman commented Mar 14, 2024

Sigh. Some vectorization issue. Didn't catch it with my scalar tests.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.59%. Comparing base (c972652) to head (758bf29).
Report is 101 commits behind head on main.

Files Patch % Lines
src/galax/dynamics/_dynamics/integrate/_builtin.py 89.65% 3 Missing ⚠️
src/galax/dynamics/_dynamics/integrate/_funcs.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   88.44%   89.59%   +1.14%     
==========================================
  Files          42       54      +12     
  Lines        1324     1854     +530     
==========================================
+ Hits         1171     1661     +490     
- Misses        153      193      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman marked this pull request as ready for review April 3, 2024 05:14
@nstarman nstarman merged commit 3bb912d into GalacticDynamics:main Apr 3, 2024
13 checks passed
@nstarman nstarman deleted the orbit-interp branch April 3, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant